Fix backward compatibility caused by missing eval metrics class #3385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dakinggg
approved these changes
Jun 8, 2024
dakinggg
reviewed
Jun 8, 2024
Co-authored-by: Mihir Patel <[email protected]>
bigning
added a commit
that referenced
this pull request
Jun 8, 2024
* a * a' * a * a * a * a * a * a * a * Apply suggestions from code review Co-authored-by: Mihir Patel <[email protected]> --------- Co-authored-by: Daniel King <[email protected]> Co-authored-by: Mihir Patel <[email protected]>
mvpatel2000
added a commit
to mvpatel2000/composer
that referenced
this pull request
Jul 21, 2024
…icml#3385) * a * a' * a * a * a * a * a * a * a * Apply suggestions from code review Co-authored-by: Mihir Patel <[email protected]> --------- Co-authored-by: Daniel King <[email protected]> Co-authored-by: Mihir Patel <[email protected]>
mvpatel2000
added a commit
that referenced
this pull request
Jul 21, 2024
* a * a' * a * a * a * a * a * a * a * Apply suggestions from code review Co-authored-by: Mihir Patel <[email protected]> --------- Co-authored-by: Daniel King <[email protected]> Co-authored-by: Mihir Patel <[email protected]>
mvpatel2000
added a commit
that referenced
this pull request
Jul 22, 2024
* a * a' * a * a * a * a * a * a * a * Apply suggestions from code review Co-authored-by: Mihir Patel <[email protected]> --------- Co-authored-by: Daniel King <[email protected]> Co-authored-by: Mihir Patel <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fix backward compatibility. We removed some metrics classes in PR #3243, which broke the backward compatibility for loading old checkpoints that have those metrics pickled.
So we add dummy class to fix this.
test: eval-7b-composer-15Qujf
eval-7b-composer-gGTskn