Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correctly process parallelism_config['tp'] when it's a dict #3434

Merged
merged 10 commits into from
Jul 8, 2024

Conversation

snarayan21
Copy link
Contributor

What does this PR do?

This fixes a bug where if the TP configuration (specified through parallelism_config['tp']) was passed in as a dict, it would not be correctly processed into the final parallelism_config. This also means that whenever we were specifying the TP config as a dict before, it was not actually being set.

Modified unit tests to make sure the TP config is actually being set.

What issue(s) does this change relate to?

Before submitting

  • Have you read the contributor guidelines?
  • Is this change a documentation change or typo fix? If so, skip the rest of this checklist.
  • Was this change discussed/approved in a GitHub issue first? It is much more likely to be merged if so.
  • Did you update any related docs and document your change?
  • Did you update any related tests and add any new tests related to your change? (see testing)
  • Did you run the tests locally to make sure they pass?
  • Did you run pre-commit on your change? (see the pre-commit section of prerequisites)

@snarayan21 snarayan21 requested a review from a team as a code owner June 28, 2024 19:22
mvpatel2000
mvpatel2000 previously approved these changes Jun 28, 2024
Copy link
Contributor

@mvpatel2000 mvpatel2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oof good catch

@snarayan21
Copy link
Contributor Author

@mvpatel2000 I keep getting errors on 4 gpu tests because it's detecting the FutureWarning and counting that as an error. I've tried filtering out these warnings but that doesn't seem to be working, including adding the warning to the pyproject.toml config for pytest. What's the right way to filter these?

@mvpatel2000
Copy link
Contributor

@mvpatel2000 I keep getting errors on 4 gpu tests because it's detecting the FutureWarning and counting that as an error. I've tried filtering out these warnings but that doesn't seem to be working, including adding the warning to the pyproject.toml config for pytest. What's the right way to filter these?

pytest.mark.filterwarning?

@snarayan21
Copy link
Contributor Author

@mvpatel2000 I already added this @pytest.mark.filterwarnings('ignore:.*(TP) is experimental.*:FutureWarning') on all relevant tests...

@mvpatel2000 mvpatel2000 dismissed their stale review June 28, 2024 20:42

Discussing

@mvpatel2000
Copy link
Contributor

@mvpatel2000 I already added this @pytest.mark.filterwarnings('ignore:.*(TP) is experimental.*:FutureWarning') on all relevant tests...

I think its a regex issue, should be \(?

@snarayan21
Copy link
Contributor Author

ah that makes sense @mvpatel2000 lemme try

Copy link
Contributor

@mvpatel2000 mvpatel2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mvpatel2000 mvpatel2000 merged commit 38a3334 into dev Jul 8, 2024
14 checks passed
@mvpatel2000 mvpatel2000 deleted the saaketh/tp_config_fix branch July 8, 2024 23:19
mvpatel2000 added a commit to mvpatel2000/composer that referenced this pull request Jul 21, 2024
…ml#3434)

* big fix

* testing

* ignore

* ignore

* ignore

* Update test_fsdp_checkpoint.py

* Update test_fsdp_checkpoint.py

---------

Co-authored-by: Mihir Patel <[email protected]>
mvpatel2000 added a commit that referenced this pull request Jul 21, 2024
* big fix

* testing

* ignore

* ignore

* ignore

* Update test_fsdp_checkpoint.py

* Update test_fsdp_checkpoint.py

---------

Co-authored-by: Mihir Patel <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants