Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[checkpoint v2] Download api #3447

Merged
merged 9 commits into from
Jul 9, 2024
Merged

[checkpoint v2] Download api #3447

merged 9 commits into from
Jul 9, 2024

Conversation

bigning
Copy link
Contributor

@bigning bigning commented Jul 1, 2024

adding the download API for monolithic checkpoint

@bigning bigning requested review from mvpatel2000 and eracah July 1, 2024 16:08
@bigning bigning marked this pull request as ready for review July 1, 2024 19:36
composer/checkpoint/download.py Outdated Show resolved Hide resolved
composer/checkpoint/download.py Show resolved Hide resolved
@bigning bigning requested a review from mvpatel2000 July 2, 2024 18:53
Copy link
Contributor

@mvpatel2000 mvpatel2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would also like review from @eracah

Copy link
Contributor

@eracah eracah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very slick! LGTM

tests/checkpoint/test_download.py Outdated Show resolved Hide resolved
@bigning bigning enabled auto-merge (squash) July 9, 2024 04:49
@bigning bigning merged commit 7656db4 into dev Jul 9, 2024
14 checks passed
@bigning bigning deleted the download_API branch July 9, 2024 05:11
mvpatel2000 pushed a commit to mvpatel2000/composer that referenced this pull request Jul 21, 2024
* a

* a

* fix lint and test

* lint

* comments

* comment
mvpatel2000 pushed a commit that referenced this pull request Jul 21, 2024
* a

* a

* fix lint and test

* lint

* comments

* comment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants