Pytest skip 2 #3448
Merged
Pytest skip 2 #3448
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 16 commits
June 24, 2024 17:54
|
(saw it was still flaky with 5 seconds :( ) |
mvpatel2000
reviewed
Jul 1, 2024
added 2 commits
July 1, 2024 14:16
added 2 commits
July 1, 2024 14:19
mvpatel2000
approved these changes
Jul 1, 2024
Co-authored-by: Mihir Patel <[email protected]>
mvpatel2000
added a commit
to mvpatel2000/composer
that referenced
this pull request
Jul 21, 2024
* test * test * test * test * test * test * fix * sleep before skip * fix * pull request target * revert * revery pr_target branches * sleep 1 * 10 sec * uncomment * dist barrier * test * dist works! * update 0.0.9 * mihir comment Co-authored-by: Mihir Patel <[email protected]> --------- Co-authored-by: v-chen_data <[email protected]> Co-authored-by: Mihir Patel <[email protected]>
mvpatel2000
added a commit
that referenced
this pull request
Jul 21, 2024
* test * test * test * test * test * test * fix * sleep before skip * fix * pull request target * revert * revery pr_target branches * sleep 1 * 10 sec * uncomment * dist barrier * test * dist works! * update 0.0.9 * mihir comment Co-authored-by: Mihir Patel <[email protected]> --------- Co-authored-by: v-chen_data <[email protected]> Co-authored-by: Mihir Patel <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR is meant to fix flakiness in composer daily test. In particular, it's suspected that pytest skip, test tmp directories are being cleared before being used during clean up, leading to directory not found. All this change does is adds a time.sleep(10) before skipping to make sure all thread directories are created before clean up process starts
What issue(s) does this change relate to?
N/A
Before submitting
pre-commiton your change? (see thepre-commitsection of prerequisites)