Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Corrected docs for MFU in SpeedMonitor #3469

Merged
merged 1 commit into from
Jul 11, 2024

Conversation

JackZ-db
Copy link
Contributor

@JackZ-db JackZ-db commented Jul 11, 2024

Corrected definition of throughput/device/mfu from "throughput/device/flops_per_sec divided by world size" to "throughput/device/flops_per_sec divided by flops available on the GPU device."

Before submitting

  • Have you read the contributor guidelines?
  • Is this change a documentation change or typo fix? If so, skip the rest of this checklist.
  • Was this change discussed/approved in a GitHub issue first? It is much more likely to be merged if so.
  • Did you update any related docs and document your change?
  • Did you update any related tests and add any new tests related to your change? (see testing)
  • Did you run the tests locally to make sure they pass?
  • Did you run pre-commit on your change? (see the pre-commit section of prerequisites)

@JackZ-db JackZ-db requested a review from j316chuck July 11, 2024 16:34
Copy link
Contributor

@j316chuck j316chuck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this!

@JackZ-db JackZ-db merged commit 7c446b2 into mosaicml:dev Jul 11, 2024
14 checks passed
mvpatel2000 pushed a commit to mvpatel2000/composer that referenced this pull request Jul 21, 2024
mvpatel2000 pushed a commit that referenced this pull request Jul 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants