-
Notifications
You must be signed in to change notification settings - Fork 431
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Checkpoint V2] Upload API #3488
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is really slick! Nice work, @bigning ! I will take a look at the unit test tmrw! One request: can we now remove the symlink upload logic from CheckpointSaver
now? We can just have CheckpointSaver
use CheckpointUploadCallback
?
@bigning, please do not attach the doc link, as not everyone would have access to it. Please add detail description on what would this PR enables and how did you test it |
@karan6181 , added the interface in the description, and also keep the design doc in the description, so reviewers could have the whole picture of all the APIs.
This was already in the description. |
Adding upload API, design doc. This API uploads the input files to remote object store, interface design:
unit test
python3 -m composer.cli.launcher -n 2 --master_port 26000 -m pytest -v --durations=20 -m 'not daily and not remote and gpu and (doctest or not doctest)' tests/checkpoint/test_upload.py