Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Load Microbatches instead of Entire Batches to GPU " #3508

Merged
merged 1 commit into from
Jul 31, 2024
Merged

Revert "Load Microbatches instead of Entire Batches to GPU " #3508

merged 1 commit into from
Jul 31, 2024

Conversation

JackZ-db
Copy link
Contributor

@JackZ-db JackZ-db commented Jul 31, 2024 •
edited
Loading

Running regression test off of this branch right now -> Saw consistently better loss and higher alloc retries.

@JackZ-db JackZ-db marked this pull request as ready for review July 31, 2024 17:54
@JackZ-db JackZ-db requested a review from a team as a code owner July 31, 2024 17:54
@JackZ-db JackZ-db requested a review from mvpatel2000 July 31, 2024 18:05
@mvpatel2000 mvpatel2000 merged commit 8390286 into dev Jul 31, 2024
14 checks passed
@mvpatel2000 mvpatel2000 deleted the revert-3487-jz/load_microbatch_to_device branch July 31, 2024 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mvpatel2000 mvpatel2000 mvpatel2000 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JackZ-db @mvpatel2000