Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change iteration timestamp for old checkpoints #3563

Merged
merged 1 commit into from
Aug 20, 2024
Merged

Conversation

b-chu
Copy link
Contributor

@b-chu b-chu commented Aug 20, 2024

What does this PR do?

When an old checkpoint is loaded, any timestamp attributes associated with iteration are 0. This means those attributes are inaccurate and can't be correctly used. This fixes old checkpoints the first time they're loaded to set those attributes to the correct value.

What issue(s) does this change relate to?

Before submitting

  • Have you read the contributor guidelines?
  • Is this change a documentation change or typo fix? If so, skip the rest of this checklist.
  • Was this change discussed/approved in a GitHub issue first? It is much more likely to be merged if so.
  • Did you update any related docs and document your change?
  • Did you update any related tests and add any new tests related to your change? (see testing)
  • Did you run the tests locally to make sure they pass?
  • Did you run pre-commit on your change? (see the pre-commit section of prerequisites)

@b-chu b-chu requested a review from mvpatel2000 August 20, 2024 17:31
@b-chu b-chu merged commit 72b2507 into mosaicml:main Aug 20, 2024
14 checks passed
@b-chu b-chu deleted the iteration branch August 20, 2024 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants