[torch2.4] Fix sharded checkpointing backward compatibility issue #3565
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvpatel2000
reviewed
Aug 20, 2024
There was a problem hiding this comment.
LGTM! A few minor style notes before approval.
Can you also please list here: https://docs.google.com/document/d/1m-qWWN3mMTmQOePx0ip5dge1I71_RKXa5QmJm2eFwh4/edit#heading=h.aoxj18348987 under monkeypatches and link github issue?
bigning
commented
Aug 20, 2024
bigning
commented
Aug 20, 2024
added to the doc |
mvpatel2000
approved these changes
Aug 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
torch 2.4 breaks the sharded checkpointing backward compatibility. It changed how the save_planner and load_planner flatten the state dict keys. Torch issue: pytorch/pytorch#133923 . So the new load planner can't load the checkpointing saved with old save_planner.
This PR monkey patches the load_planner if it failed to load an old checkpoint, then it removes the patch after loading the checkpointing.
test
daily test: https://github.com/mosaicml/composer/actions/runs/10480275642
