Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to log.info for deterministic mode #3643

Merged
merged 5 commits into from
Oct 4, 2024

Conversation

mvpatel2000
Copy link
Contributor

What does this PR do?

Switch to log.info as this isn't something going wrong that requires user intervention. If a user intentionally sets this, it should not result in a warning.

Most frequently, this results in spurious warnings in our Ci/CD

Copy link
Contributor

@snarayan21 snarayan21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

according to PR description, likely log.info right?

composer/utils/reproducibility.py Outdated Show resolved Hide resolved
@mvpatel2000 mvpatel2000 requested a review from snarayan21 October 4, 2024 01:41
Copy link
Contributor

@snarayan21 snarayan21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mvpatel2000 mvpatel2000 merged commit cf3844f into mosaicml:main Oct 4, 2024
14 checks passed
@mvpatel2000 mvpatel2000 deleted the mvpatel2000/logger branch October 4, 2024 02:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants