Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Speed up CI tests :) #3727

Merged
merged 58 commits into from
Dec 2, 2024
Merged

Speed up CI tests :) #3727

merged 58 commits into from
Dec 2, 2024

Conversation

KuuCi
Copy link
Contributor

@KuuCi KuuCi commented Nov 29, 2024

What does this PR do?

As our stack grows, we need to make sure that our CI tests is efficient and fast! (referencing https://github.com/mosaicml/composer/actions/runs/12059801726/job/33629067025 for test speed comparisons)
Old 1 GPU test:
image

New 1 GPU test:
image

Old 2 GPU test:
image

New 2 GPU test:
image

Annecdotally seeing around a 2-2:30 min speed up on 1 gpu tests and a 30 sec speed up on 2 gpu test

What issue(s) does this change relate to?

N/A

Before submitting

  • Have you read the contributor guidelines?
  • Is this change a documentation change or typo fix? If so, skip the rest of this checklist.
  • Was this change discussed/approved in a GitHub issue first? It is much more likely to be merged if so.
  • Did you update any related docs and document your change?
  • Did you update any related tests and add any new tests related to your change? (see testing)
  • Did you run the tests locally to make sure they pass?
  • Did you run pre-commit on your change? (see the pre-commit section of prerequisites)

@KuuCi
Copy link
Contributor Author

KuuCi commented Dec 2, 2024

my debt has been paid @mvpatel2000

@KuuCi KuuCi requested review from mvpatel2000 and bigning December 2, 2024 00:30
@KuuCi KuuCi marked this pull request as ready for review December 2, 2024 00:31
@KuuCi KuuCi requested a review from snarayan21 December 2, 2024 00:31
Copy link
Contributor

@mvpatel2000 mvpatel2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yung king

@KuuCi KuuCi merged commit d10d442 into main Dec 2, 2024
14 checks passed
@KuuCi KuuCi deleted the speed-ci-tests branch December 2, 2024 18:56
@snarayan21 snarayan21 mentioned this pull request Dec 3, 2024
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants