fix issue #15 #16
Merged
fix issue #15 #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hmm. Now I'm getting, this is happening only when you're not in strict mode and send an empty request, so seems that who are in strict mode isn't affected (because it would fail). |
| while (null != (chunk = socket.read())) { | ||
| chunk = socket.read(); | ||
|
|
||
| if(null === chunk && header.length === 0){ |
There was a problem hiding this comment.
Can you please add here a non-strict condition filter?
! options.strict && null === chunk && header.length === 0
There was a problem hiding this comment.
And also run your tests to check if this affects somehow your fix? Cheers
|
Problem arises on both scenarios. I have updated the test to cover both scenarios. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit aims to fix issue #15
Explanation:
The wrapper does not handle properly a socket that close before any write.
I know the code formatting of file
test/fix-issue-15is not the convention you are following in this project.I will reformat the file if you explain to me what are your preferences.