Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove TODO comments #876

Merged
merged 11 commits into from
Apr 27, 2021
Merged

Conversation

jennyfothergill
Copy link
Contributor

@jennyfothergill jennyfothergill commented Apr 27, 2021

PR Summary:

  • all TODO comments were removed and converted to issues.

Fixes #872

PR Checklist


  • Includes appropriate unit test(s)
  • Appropriate docstring(s) are added/updated
  • Code is (approximately) PEP8 compliant
  • Issue(s) raised/addressed?

@codecov
Copy link

codecov bot commented Apr 27, 2021

Codecov Report

Merging #876 (1ded05c) into master (a9d9e3e) will not change coverage.
The diff coverage is 80.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #876   +/-   ##
=======================================
  Coverage   88.39%   88.39%           
=======================================
  Files          62       62           
  Lines        7857     7857           
=======================================
  Hits         6945     6945           
  Misses        912      912           
Impacted Files Coverage Δ
mbuild/coarse_graining.py 90.67% <ø> (ø)
mbuild/compound.py 97.57% <ø> (ø)
mbuild/conversion.py 89.26% <ø> (ø)
mbuild/coordinate_transform.py 91.60% <ø> (ø)
mbuild/lib/surfaces/amorphous_silica_surface.py 100.00% <ø> (ø)
mbuild/formats/lammpsdata.py 87.65% <66.66%> (ø)
mbuild/formats/protobuf.py 92.00% <100.00%> (ø)
mbuild/pattern.py 90.22% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a9d9e3e...1ded05c. Read the comment docs.

@justinGilmer justinGilmer merged commit 1ca3ff8 into mosdef-hub:master Apr 27, 2021
@jennyfothergill jennyfothergill deleted the no/todos branch May 12, 2021 17:28
umesh-timalsina referenced this pull request in GOMC-WSU/MoSDeF-GOMC Mar 22, 2022
* remove todo, see issue #875

* see #877

* see #878

* see #879

* see #880

* see #881

* see #882

* see #883

* see #884

* see #885

* see #886
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove TODO's from code and convert to issues
3 participants