Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RTL is not handled in inji app #203

Closed
Anushree09-N opened this issue Nov 4, 2022 · 9 comments
Closed

RTL is not handled in inji app #203

Anushree09-N opened this issue Nov 4, 2022 · 9 comments
Assignees
@krishnakumar4a4 @PoojaBabusing
Labels
beta_must_fix bug Something isn't working Critical HotFix Hotfix release moved-to-jira triaged Triage completed

Comments

@Anushree09-N
Copy link

Anushree09-N commented Nov 4, 2022 •
edited
Loading

Describe the bug
RTL is not handled in inji app

To Reproduce

  1. unlock the app
  2. In the right top click on language icon
  3. select Arabic language

Current behavior
RTL is not handled in inji app.

Expected behavior
Arabic language should be rendered from right to left.

Screenshots
File (4)
File (5)

Smartphone (please complete the following information):

  • Device: iPhone7 & iPhone XR
  • OS: 15.4.1
  • Inji app version: 0.4.0 (16) in test flight
  • MOSIP Version: 1.2.1
  • MOSIP server: qa-121.mosip.net

Additional context
Issue registered for Android app #197
@Anushree09-N Anushree09-N added bug Something isn't working triage This issue is pending confirmation and planning and should not be worked on yet Critical labels Nov 4, 2022
@kyanthony kyanthony moved this from Analysis to Development in MOSIP Inji issues tracking Nov 4, 2022
@Sujithbn Sujithbn removed the triage This issue is pending confirmation and planning and should not be worked on yet label Nov 7, 2022
@Sujithbn
Copy link

Sujithbn commented Nov 7, 2022

This will be included in the Facenet android New logic build( ).

@Sujithbn Sujithbn added the triaged Triage completed label Nov 7, 2022
@kyanthony kyanthony moved this from Development to Merged in MOSIP Inji issues tracking Nov 8, 2022
@rakhimosip rakhimosip mentioned this issue Nov 8, 2022
Closed
pmigueld added a commit that referenced this issue Nov 9, 2022
@pmigueld
Merge pull request #255 from idpass/203/rtl-support
81ba102 
#203 RTL is not handled in inji app
@pmigueld pmigueld mentioned this issue Nov 9, 2022
Merged
@kyanthony kyanthony moved this from Merged to QA (test) in MOSIP Inji issues tracking Nov 9, 2022
@kyanthony kyanthony moved this from QA (test) to Merged in MOSIP Inji issues tracking Nov 9, 2022
@danicaerediano danicaerediano mentioned this issue Nov 10, 2022
Merged
@kyanthony kyanthony moved this from Merged to QA (test) in MOSIP Inji issues tracking Nov 15, 2022
@jannahadlaon
Copy link

jannahadlaon commented Nov 16, 2022 •
edited
Loading

Tested on:
iOS: 0.4.1 (1)

STEPS

  1. Open the app
  2. In the right top click on language icon
  3. select Arabic language

WORKS AS EXPECTED
@kyanthony @pmigueld @danicaerediano

Screenshots
IMG_2247
IMG_2248

Devices:
iPhone 11 - iOS 16.1

@Sujithbn Sujithbn assigned Anushree09-N and unassigned Sujithbn Nov 30, 2022
@Anushree09-N
Copy link
Author

Verified on:

Device: iPhone 8 & iPhone 11
OS: 16.0.2 (20A380), 15.6.1
Inji app version: 0.4.1 (4) -> Testflight
MOSIP Version: 1.2.0.1
MOSIP server: qa5.mosip.net

@jannahadlaon below are the scenario's where RTL is still not handled properly.

  1. User guide messages are still read from left to right and cancel icon is overlapped on the text.

image

  1. UIN being inserted from left to right

image
image

  1. Otp screen

image

  1. Message display while sharing vc
    image

image
image
image

  1. success message after sharing
    image
    image

  2. Profile section >> Name field -Text is being inserted from left to right and behaviour is same in Label , Renaming feature
    image

  3. Profile section >> Credits and Legal page -not all data is being read from left to right
    image

  4. data in qr code screen

image

  1. Message display in requesting device

image
image

Due to above listed issue we will keep this ticket open.

@kyanthony kyanthony moved this from QA (test) to Pending input / clarification in MOSIP Inji issues tracking Jan 19, 2023
@kyanthony kyanthony moved this from Pending input / clarification to Development in MOSIP Inji issues tracking Jan 20, 2023
@pmigueld pmigueld mentioned this issue Jan 20, 2023
Merged
pmigueld added a commit that referenced this issue Jan 22, 2023
@pmigueld
fix(#203): RTL issues
26de1b4
@jannahadlaon
Copy link

Tested on:
iOS: Inji version 0.4.1 (12)

WORKS AS EXPECTED
some of the texts were not translated but in RTL format
@pmigueld @santhoshsunder @kyanthony @Anushree09-N

Devices
iPhone 11 - iOS 16.1.2
iPhone SE - iOS 15.4

Screenshot
IMG_3727
IMG_3728
IMG_3729
IMG_3730
IMG_3732
IMG_3733
IMG_3734
IMG_3731

@kyanthony kyanthony moved this from Development to QA (test) in MOSIP Inji issues tracking Jan 24, 2023
@kyanthony kyanthony assigned Sujithbn and unassigned pmigueld and kyanthony Jan 24, 2023
@Sujithbn Sujithbn assigned Anushree09-N and unassigned Sujithbn Jan 30, 2023
@Raginikrishnamurthy
Copy link
Contributor

@Sujithbn Please check if the PR is merged in develop branch and re-assign to qa.

@Sujithbn Sujithbn added BLE-Sharing Related to BLE sharing mechanism and removed BLE-Sharing Related to BLE sharing mechanism labels Mar 14, 2023
@santhoshsunder
Copy link
Contributor

In the RTL the app is not having a header highlighted on the home page, please look into the screen recording for reference, since it is not highlighted, we are not able to make out, on which screen we are , it is occurring in both themes, please look into this

Screenshot :
https://user-images.githubusercontent.com/102220709/227505681-6910bd4c-353a-49c4-936d-6690711ce173.mp4
https://user-images.githubusercontent.com/102220709/227505769-d084acd9-d3d0-42e3-86af-87100a2149c3.mp4

Smartphone :
device : redmi k20 pro
ble : 5.0
android : 11
MOSIP Version : 1.2.0.1
MOSIP server : qa-1201-b2.net
APP link : https://github.com/mosip/inji/actions/runs/4447486079

@Sujithbn Sujithbn moved this from QA (test) to Pending input / clarification in MOSIP Inji issues tracking Mar 28, 2023
@Sujithbn Sujithbn assigned krishnakumar4a4 and unassigned Sujithbn Apr 3, 2023
@Sujithbn Sujithbn added the HotFix Hotfix release label Apr 3, 2023
@Pragya279
Copy link

This bug has been moved to Jira.
Link to Jira bug: https://mosip.atlassian.net/browse/MOSIP-26839

@krishnakumar4a4 krishnakumar4a4 moved this from Pending input / clarification to Analysis in MOSIP Inji issues tracking Apr 4, 2023
@Raginikrishnamurthy
Copy link
Contributor

Issue verified and closed on jira https://mosip.atlassian.net/browse/INJI-36, hence closing the same on Github.

@github-project-automation github-project-automation bot moved this from Analysis to Merged in MOSIP Inji issues tracking Oct 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@krishnakumar4a4 krishnakumar4a4

@PoojaBabusing PoojaBabusing

Labels
beta_must_fix bug Something isn't working Critical HotFix Hotfix release moved-to-jira triaged Triage completed
Projects
MOSIP Inji issues tracking
Status: Merged
Milestone
No milestone
Development

No branches or pull requests