Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Message should be revised in sharing device while waiting for receiver to accept VC #210

Closed
Anushree09-N opened this issue Nov 6, 2022 · 10 comments
Assignees
Labels
beta_must_fix bug Something isn't working Minor triaged Triage completed

Comments

@Anushree09-N
Copy link

Describe the bug
Message should be revised in sharing device while waiting for receiver to accept VC

Prerequisite Download VC in sharing phone.

To Reproduce

  1. unlock the app
  2. Open qr code in requesting device.
  3. Open scanner in sharing device and scan the qrcode
  4. select VC and click on Accept and share button
  5. Incoming VC in requesting phone and message pop-up button in sharing phone.

Current behavior
When receiver is about to Accept incoming VC the sharing device will have message saying "It's taking a while to share VC. There could be a problem with the connection".

Expected behavior
Though both devices are connected message is misleading user saying "There could be a problem with the connection". which should be revised.

Screenshots
IMG_0044 (1)

Smartphone (please complete the following information):

  • Device: iPhone7 & iPhone XR
  • OS: 15.4.1
  • Inji app version: 0.4.0 (16) in test flight
  • MOSIP Version: 1.2.1
  • MOSIP server: qa-121.mosip.net
@Anushree09-N Anushree09-N added bug Something isn't working triage This issue is pending confirmation and planning and should not be worked on yet Minor labels Nov 6, 2022
@Sujithbn Sujithbn added triaged Triage completed beta_must_fix and removed triage This issue is pending confirmation and planning and should not be worked on yet labels Nov 7, 2022
@Sujithbn Sujithbn added this to the Sprint-16 23 Nov 22 milestone Nov 8, 2022
@Sujithbn Sujithbn moved this to To do (under triage) in MOSIP Inji issues tracking Nov 8, 2022
Nambirajanr pushed a commit to Nambirajanr/inji that referenced this issue Nov 10, 2022
@rakhimosip
Copy link
Contributor

As the VC has already been shared by the sender and it has reached the requestor's device we can revise the message displayed on the sender's device as "The credential has been shared. Waiting for the requestor to accept it."

@rakhimosip rakhimosip removed their assignment Dec 8, 2022
@Sujithbn Sujithbn moved this from To do (under triage) to Development in MOSIP Inji issues tracking Dec 12, 2022
@Anushree09-N
Copy link
Author

Unable to verify the ticket due to linked issue #370

@kyanthony kyanthony moved this from Development to Pending input / clarification in MOSIP Inji issues tracking Jan 3, 2023
@jannahadlaon
Copy link

Tested on
Android: COLLAB_io.mosip.residentapp-0.4.1-rc5-newlogic_20221216_1728.apk
iOS: Inji 0.4.1 (7)

Message was revised to: It's taking a while to establish connection. Is the other device open for connection? (refer to screenshot)
@pmigueld @danicaerediano @Anushree09-N @kyanthony @rakhimosip @Sujithbn

To Reproduce
Steps to reproduce the behavior:

  1. unlock the app
  2. Open qr code in requesting device.
  3. Open scanner in sharing device and scan the qrcode
  4. select VC and click on Accept and share button
  5. Incoming VC in requesting phone and message pop-up button in sharing phone.

Test devices:
iPhone 11 - iOS 16.1.1
Samsung Galaxy A23 - Android 12

Screenshot
Screenshot_20230103-162903_MOSIP Resident App

@kyanthony kyanthony moved this from Pending input / clarification to Committed in MOSIP Inji issues tracking Jan 16, 2023
@pmigueld
Copy link
Contributor

Here's a screenshot of updated text:

image

@kyanthony
Copy link

@rakhimosip please have look and let us know if it's good to close.
cc @Sujithbn

@rakhimosip
Copy link
Contributor

@kyanthony one question -> Is the text 'ID' in the above message coming from the 'VC Label' set in the Profile section? If yes, then the above message works for this scenario.
CC @Anushree09-N @pmigueld @jannahadlaon

@rakhimosip rakhimosip removed their assignment Jan 18, 2023
@pmigueld
Copy link
Contributor

@rakhimosip yes, it is the vcLabel set in profile.

@rakhimosip
Copy link
Contributor

Thanks, @pmigueld

@Anushree09-N @jannahadlaon the above message looks good. Please test and close.

CC @kyanthony

@kyanthony kyanthony moved this from Committed to QA (test) in MOSIP Inji issues tracking Jan 19, 2023
@jannahadlaon
Copy link

tested on:
iOS: Inji version 0.4.1 (12)

WORKS AS EXPECTED
@pmigueld @santhoshsunder @kyanthony

Steps

  1. unlock the app
  2. Open qr code in requesting device.
  3. Open scanner in sharing device and scan the qrcode
  4. select VC and click on Accept and share button
  5. Incoming VC in requesting phone and message pop-up button in sharing phone.

Devices
iPhone 11 - iOS 16.1.2
iPhone SE - iOS 15.4

Screenshot

IMG_0106
IMG_0107

@damodarguru
Copy link

Verified this issue in qa-1201-b2 environment, we getting appropriate popup message when we sharing VC and waiting for receiver for receiving VC card. I am attaching the screenshot and the device details below for reference. Hence closing the bug.

Screenshots:
image
image
image
image
image
image
image

Tested in:
Device: iPhone7
OS: 15.6.1
Inji app version: 0.4.0 (32) in test flight

Device: Samsung Galaxy A03 core
Android Version: 11
BLE version : 4.2
Inji app link: https://github.com/mosip/inji/actions/runs/4511525622
Mimoto version: 1.2.0.1
MOSIP Version: qa-1201-b2.mosip.net

@github-project-automation github-project-automation bot moved this from QA (test) to Merged in MOSIP Inji issues tracking Mar 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beta_must_fix bug Something isn't working Minor triaged Triage completed
Projects
Status: Merged
Development

No branches or pull requests

9 participants