Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Message popup in sharing device is still retained even after successful VC share. #214

Closed
Anushree09-N opened this issue Nov 7, 2022 · 4 comments
Closed

Message popup in sharing device is still retained even after successful VC share. #214

Anushree09-N opened this issue Nov 7, 2022 · 4 comments
Assignees
@pmigueld @kyanthony
Labels
beta_must_fix bug Something isn't working Critical triaged Triage completed

Comments

@Anushree09-N
Copy link

Describe the bug
Message popup in sharing device is still retain even after successful VC share.

To Reproduce

  1. open qrcode in Android app (online mode)
  2. open scanner in iOS device
  3. scan the qrcode from iOS device
  4. After establishing connection choose VC and click on AcceptRequest button .
  5. will see incoming VC in requesting device and message popup in sharing device.
  6. Accept the incoming VC -> success message popup is displayed.
  7. Check the message pop in sharing device

Current behavior
Message popup in sharing device is still retain even after successful VC share.

Expected behavior
As VC share was success the message pop up in share device should dismiss the message automatically.

Screenshots
File (14)

Smartphone (please complete the following information):
@Anushree09-N Anushree09-N added bug Something isn't working triage This issue is pending confirmation and planning and should not be worked on yet Major labels Nov 7, 2022
@Anushree09-N Anushree09-N changed the title Message popup in sharing device is still retain even after successful VC share. Message popup in sharing device is still retained even after successful VC share. Nov 7, 2022
@Sujithbn Sujithbn added triaged Triage completed beta_must_fix and removed triage This issue is pending confirmation and planning and should not be worked on yet labels Nov 7, 2022
@Anushree09-N
Copy link
Author

@rakhimosip this issue is inconsistent and also observed that if sharing device dismiss the message automatically the history is being captured otherwise we will not see history for sharing . Hence increasing the severity to critical

@rakhimosip rakhimosip assigned kyanthony and unassigned rakhimosip Nov 8, 2022
Nambirajanr pushed a commit to Nambirajanr/inji that referenced this issue Nov 10, 2022
@danicaerediano
Merge pull request mosip#214 from idpass/bugfix/208-disconnected
10fbc5f 
[ICA-208] Sharing device remains in sharing state when Requesting phone gets disconnected (like network issue)
@kyanthony kyanthony moved this to To do (under triage) in MOSIP Inji issues tracking Nov 14, 2022
@kyanthony kyanthony moved this from To do (under triage) to Development in MOSIP Inji issues tracking Nov 14, 2022
@pmigueld pmigueld mentioned this issue Nov 23, 2022
Merged
6 tasks
pmigueld added a commit that referenced this issue Nov 23, 2022
@pmigueld
fix(#214): increase sharing timeout
e99347f
@pmigueld pmigueld mentioned this issue Nov 23, 2022
Merged
@Sujithbn Sujithbn assigned Anushree09-N and unassigned pmigueld and kyanthony Nov 23, 2022
@Sujithbn Sujithbn moved this from Development to QA (test) in MOSIP Inji issues tracking Nov 23, 2022
@jannahadlaon
Copy link

Tested on:
Android: QA4_io.mosip.residentapp-0.4.1-beta.1-10-d68f577-feature_mosip-55-face-matching-newlogic_20221115_1441.apk

Assign back to dev
Issue is still present

STEP:

  1. Open qrcode in Android app (online mode)
  2. Open scanner in iOS device
  3. Scan the qrcode from iOS device
  4. After establishing connection choose VC, and share.
  5. Accept the incoming VC in the receiving device -> success message popup is displayed -> CLICK ANYWHERE ON THE RECEIVING DEVICE before the success message is displayed on the sharing device.
  6. See error on the sharing device.

@kyanthony @pmigueld @danicaerediano

Devices:
Samsung Galaxy A23 - Android 12
iPhone 11 - iOS 16.1.1

Screenshot
https://user-images.githubusercontent.com/102940764/203754150-1bdd1465-16a7-46ad-908f-d0c3aa405be9.mov

@kyanthony kyanthony assigned pmigueld and kyanthony and unassigned Anushree09-N Nov 30, 2022
@kyanthony kyanthony moved this from QA (test) to Development in MOSIP Inji issues tracking Nov 30, 2022
@pmigueld pmigueld mentioned this issue Dec 16, 2022
Merged
@jannahadlaon
Copy link

Tested on
Android: COLLAB_io.mosip.residentapp-0.4.1-rc5-newlogic_20221216_1728.apk
iOS: Inji 0.4.1 (7)

Issue is still present
@pmigueld @danicaerediano @Anushree09-N @kyanthony @rakhimosip @Sujithbn

To Reproduce
Steps to reproduce the behavior:

  1. Open qrcode in Android app (online mode)
  2. Open scanner in iOS device
  3. Scan the qrcode from iOS device
  4. After establishing connection choose VC, and share.
  5. Accept the incoming VC in the receiving device -> success message popup is displayed -> CLICK ANYWHERE ON THE RECEIVING DEVICE before the success message is displayed on the sharing device.
  6. See error on the sharing device.

Test devices:
iPhone 11 - iOS 16.1.1
Samsung Galaxy A23 - Android 12

Screenshot

IMG_0076.MOV

FullSizeRender

@Anushree09-N
Copy link
Author

Verified on:
Device : iPhone 8 & OnePlus Nord 2
OS: 16.0.2
Inji app version: 0.4.1 (7) -> Testflight
MOSIP Version: 1.2.0.1
MOSIP server: qa5.mosip.net

Working as expected , Displayed success pop up message on sharing device .

https://drive.google.com/file/d/1OecsTUI_bcmTYBWnhbvx1RrQlS2a0lc3/view?usp=share_link

Repository owner moved this from Development to Merged in MOSIP Inji issues tracking Dec 22, 2022
@Sujithbn Sujithbn moved this from Merged to Closed in MOSIP Inji issues tracking Dec 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pmigueld pmigueld

@kyanthony kyanthony

Labels
beta_must_fix bug Something isn't working Critical triaged Triage completed
Projects
MOSIP Inji issues tracking
Status: Closed
Milestone
No milestone
Development

No branches or pull requests
6 participants
@pmigueld @Anushree09-N @rakhimosip @jannahadlaon @kyanthony @Sujithbn