Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error message should be revised when biometrics is not enrolled in device settings page but still resident use biometric unlock #260

Closed
santhoshsunder opened this issue Nov 18, 2022 · 2 comments
Assignees
Labels
beta_must_fix bug Something isn't working Minor triaged Triage completed

Comments

@santhoshsunder
Copy link
Contributor

Describe the bug
Error message should be revised when biometrics is not enrolled in device settings page but still resident use biometric unlock feature

To Reproduce
Prerequisite : make sure there is no biometrics for authentication where added in the mobile
1.Install the inji app
2.Click on Get started button
3.Displays two option ---- Biometrics unlock
I would rather use passcode
4.click on biometrics unlock button

Current behavior
Displayed error message as "To use Biometrics, please enroll your fingerprint in your device settings".

Expected behavior
As smart phones supports biometric unlock with face and also with fingerprint , the error message can say user to enroll your "biometrics" in device settings page instead of saying specifically to set fingerprint.

Screenshots
image

Smartphone (please complete the following information):
Device: android
MOSIP Version: 121
MOSIP server: qa-121.mosip.net
APK link : https://github.com/mosip/inji/actions/runs/3287270987

@santhoshsunder santhoshsunder added bug Something isn't working triage This issue is pending confirmation and planning and should not be worked on yet labels Nov 18, 2022
pmigueld pushed a commit that referenced this issue Nov 23, 2022
In inji app still labels and button remained in english even after language switch
@rakhimosip rakhimosip added triaged Triage completed and removed triage This issue is pending confirmation and planning and should not be worked on yet labels Dec 8, 2022
@Sujithbn Sujithbn assigned kyanthony and unassigned Sujithbn Dec 8, 2022
@kyanthony kyanthony moved this to Development in MOSIP Inji issues tracking Dec 8, 2022
pmigueld added a commit that referenced this issue Dec 12, 2022
#259 #260 Error message should be revised when biometrics is not enrolled in device settings page but still resident use biometric unlock
@jannahadlaon
Copy link

Tested on
Android: COLLAB_io.mosip.residentapp-0.4.1-rc5-newlogic_20221216_1728.apk

WORKS AS EXPECTED
@pmigueld @danicaerediano @Anushree09-N @kyanthony @rakhimosip @Sujithbn

Test devices:
Samsung Galaxy A23 - Android 12

Screenshot
Screenshot_20221219-151845_MOSIP Resident App

@Sujithbn Sujithbn assigned Anushree09-N and unassigned kyanthony Dec 19, 2022
@Sujithbn Sujithbn moved this from Development to QA (test) in MOSIP Inji issues tracking Dec 19, 2022
@santhoshsunder
Copy link
Contributor Author

Verified this issue in QA5 env, issue is not observed any more, the message is projected as expected, iam attaching the current working screenshot, hense closing this bug

Screenshot :
image
image

Smartphone :

Repository owner moved this from QA (test) to Merged in MOSIP Inji issues tracking Dec 23, 2022
@Sujithbn Sujithbn moved this from Merged to Closed in MOSIP Inji issues tracking Jan 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beta_must_fix bug Something isn't working Minor triaged Triage completed
Projects
Status: Closed
Development

No branches or pull requests

8 participants