Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dynamicconfig: implement control plane (1/n) #707

Merged
merged 1 commit into from
Sep 6, 2024
Merged

dynamicconfig: implement control plane (1/n) #707

merged 1 commit into from
Sep 6, 2024

Conversation

spacewander
Copy link
Member

No description provided.

@github-actions github-actions bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Sep 3, 2024
Copy link

codecov bot commented Sep 3, 2024

Codecov Report

Attention: Patch coverage is 83.49515% with 34 lines in your changes missing coverage. Please review.

Please upload report for BASE (main@c0c4192). Learn more about missing BASE report.
Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
...er/internal/controller/dynamicconfig_controller.go 64.70% 15 Missing and 9 partials ⚠️
types/apis/v1/dynamicconfig_types.go 57.14% 8 Missing and 1 partial ⚠️
controller/internal/controller/component/k8s.go 88.88% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #707   +/-   ##
=======================================
  Coverage        ?   88.23%           
=======================================
  Files           ?      123           
  Lines           ?     6198           
  Branches        ?        0           
=======================================
  Hits            ?     5469           
  Misses          ?      521           
  Partials        ?      208           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions github-actions bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Sep 3, 2024
@spacewander spacewander marked this pull request as ready for review September 3, 2024 06:33
@spacewander spacewander merged commit 3dbd5a2 into main Sep 6, 2024
16 checks passed
@spacewander spacewander deleted the 903 branch September 6, 2024 02:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant