Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to crystal 0.24 #10

Merged
merged 1 commit into from
Jun 7, 2018
Merged

Update to crystal 0.24 #10

merged 1 commit into from
Jun 7, 2018

Conversation

bcardiff
Copy link
Contributor

There are some breaking changes and known issues with 0.24 that should be fixed by the following changes.

Copy link

@elorest elorest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@elorest
Copy link

elorest commented Dec 27, 2017

Tests error because travis is still using 0.23.1.

@DmitryBochkarev
Copy link

@bcardiff, please merge this request, it's blocking migration to 0.24.1

@bcardiff
Copy link
Contributor Author

bcardiff commented Jan 9, 2018

@DmitryBochkarev it's not on me to merge this :-) @mosop is the owner of the repo

@DmitryBochkarev
Copy link

oh, I'm sorry, I just have little sick and mixed up who is the owner of the repository

@elorest
Copy link

elorest commented Jan 9, 2018 via email

@mosop mosop merged commit 4f5f5e3 into mosop:master Jun 7, 2018
@mosop
Copy link
Owner

mosop commented Jun 7, 2018

Thank you all!

@mosop
Copy link
Owner

mosop commented Jun 7, 2018

fixed #13

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants