Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add support for loading PEM certificates as string as well as file path #221

Merged
merged 3 commits into from
Jun 1, 2023
Merged

feat: add support for loading PEM certificates as string as well as file path #221

merged 3 commits into from
Jun 1, 2023

Conversation

doxsch
Copy link
Contributor

@doxsch doxsch commented May 31, 2023

…eferences to files

closes: #171

mostafa
mostafa requested changes Jun 1, 2023
View reviewed changes
Copy link
Owner

@mostafa mostafa left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution! 🙏 These are a few nitpicks. Applied them already.

auth.go Outdated Show resolved Hide resolved
auth.go Show resolved Hide resolved
auth.go Outdated Show resolved Hide resolved
auth.go Outdated Show resolved Hide resolved
auth.go Outdated Show resolved Hide resolved
@mostafa mostafa changed the title feat: add support to add PEM certificates as string instead of path r… feat: add support for loading PEM certificates as string as well as file path Jun 1, 2023
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jun 1, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@mostafa mostafa merged commit 912ba4d into mostafa:main Jun 1, 2023
@mostafa mostafa mentioned this pull request Jun 1, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mostafa mostafa mostafa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feature request: possibility to add PEM certificates as string instead of path references to files
2 participants
@doxsch @mostafa