Add tests #60
Merged
Add tests #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 12, 2022
* Update deserializer function interface and add topic * Revamp avro.go to address multiple issues (fetching schemas, manual serialization, etc.) * Add more error codes and errors * Separate various Schema Registry functions * Simplify serialization functions * Explicitly pass srClient to SR functions * Export all functions * Fix tests to reflect changes
* Add tests to serde_registry.go
|
Kudos, SonarCloud Quality Gate passed!
|
mostafa
added a commit
that referenced
this pull request
May 31, 2022
* Add test for string.go * Add test for bytearray.go * Add test for errors.go * Add test for auth.go * Fix linter errors * Fix tests after rebasing with the logging/error-reporting PR merge * Remove the old ReportErrors function and test * Run Go tests in the test pipeline * Add more tests to auth_test.go after refactoring loggin and error-reporting * Refactor functions a bit until proper configuration validation is implemented * Fix assertions * Remove schema from function signatures (unused parameter) * Add tests for serde.go * Add tests for avro.go * Update deserializer function interface and add topic * Revamp avro.go to address multiple issues (fetching schemas, manual serialization, etc.) * Add more error codes and errors * Separate various Schema Registry functions * Simplify serialization functions * Explicitly pass srClient to SR functions * Export all functions * Fix tests to reflect changes * Fix linter error * Add more tests to SerializeAvro * Refactor serde and add serde registry * Add tests to serde_registry.go * Rename schema registry module * Remove duplicate code by using a function to get a connection to Kafka * Add tests to configuration.go * Update jsonschema.go with the latest changes to schema registry * Add tests to jsonschema.go * Add more test to avro.go * Add tests to jsonschema.go * Add tests to schema_registry.go * Create coverage report * Fix linter errors * Remove duplicate tests * Refactor configuration_test.go * Use constants * Fix typo * Ignore act * Add tests to topic.go * Run lensesio/fast-data-dev container for testing against Kafka * Use title case * Assert module instance and runtime * WIP: Add tests to producer.go (has issues with default function) * Rename kafkatest.go so it doesnt' get included in non test builds * Make test being able to go to vu code mode and other fixes * Create topic before producing messages * Check output metrics of produce function plus some fixes * Fix bugs and add some TODO comments * Add more tests to producer.go * Fix typos * Separate nil context from cancelled context error * Fix an edge case with setting offset together with groupID * Fix tests * Add tests to consumer.go (buggy) * Add more tests to consumer.go and fix others Co-authored-by: Mihail Stoykov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses the following issue and includes unit tests, integration tests, and E2E tests. I tried my best to fix issues while writing these tests and, at some point, asked for help from @mstoykov, which he kindly offered, as always. 🙏
These tests prove that the extension needs serious refactoring to become stable, as mentioned in #44. Also, I'll add more tests over time, either when new features are added or when more edge cases are found. All in all, I hope these tests contribute to the overall stability and reliability of this extension.
While adding tests, I also fixed the test pipeline and introduced a few different tools and steps, in hope that it prevents future issues. 🤞