Minor fix and improve

[davidlatwe]

This PR propose to add profiles_path to allzparkconfig.py, which would optionally allow to exclude profile packages path from Rez's packages_path when working out side of Allzpark.

Beside that, this PR also...

• A few doc strings been updated, and closed the if-statement clause in list_profile in 2df97d8.
• Log messages' line break and space are now preserved in console widget.

[mottosso]

Thanks for this!

Now, what's the motivation? Was there a problem having profiles mixed with other packages? I'm not keen on making Allzpark behave differently from Rez on the command-line. It's meant to act as a visual version of that. This seems to produce different search results, one including profiles and the other not. :S

[davidlatwe]

Just found out that this profiles_path implementation missed one spot (and it's a TODO 😁 ) :

allzpark/allzpark/model.py

Lines 359 to 363 in 62ed58d

	# TODO: This isn't nice. The model should
	# not have to reach into the controller.
	paths = self._ctrl._package_paths()

The profile package's "versions" cannot be found when viewing Package page.

Edit :
No need to worry about this now, at least in this PR.

[davidlatwe]

Now, what's the motivation? Was there a problem having profiles mixed with other packages?

Yes, mainly hope to opt-out profile packages when, for example using rez-search in command-line.
Since I think (at least on what I have known about Rez) using

$ rez-search --paths [profile path]

to find all profiles when needed, is nicer than filtering out profiles when you just need to find regular packages (which I imaging this would happens really often).

[davidlatwe]

This seems to produce different search results, one including profiles and the other not. :S

Yes, that was the idea :P

Oh, the profiles_path is optional, completely up to user preference.
I liked this was because I also made a package which provide a tool to create/build profile package and listing them.
Which allows me to manage them differently. :)

[davidlatwe]

Sorry for the chaos, I reviewed my changes again and looks like all I need was to add back those profile path in Controller._package_paths. :)

[davidlatwe]

looks like all I need was to add back those profile path in Controller._package_paths. :)

Hmmm.., after I found that and re-think about what you have said, instead of adding profiles_path in there, why not just use additional rezconfig.py with different packages_path setup ? 🤔

I'll revert the profiles_path feature, and leave those minor fixes. 🚧

[mottosso]

why not just use additional rezconfig.py with different packages_path setup ?

Ooo, yes that would be much preferable. I hope you get what I'm saying; it's important to preserve the use of command-line as an alternative to Allzpark. Allzpark is sugar on-top of Rez, nothing more. If you think of new features or use, we'll either have to find a way to do it with vanilla-Rez (like you seem to have done just now) or think long and hard about whether and how to deviate with Allzpark.

[davidlatwe]

After I switch to use additional rezconfig.py, I got an error says:

rez.exceptions.RezPluginError: Unrecognised package repository plugin: '/Users/davidlatwe/mongozark'

Turns out my mongodb based package repository path ([email protected]) got normpathsed here 👇🏼

allzpark/allzpark/control.py

Lines 941 to 945 in 62ed58d

	def _package_paths(self):
	"""Return all package paths, relative the current state of the world"""
	paths = util.normpaths(*rez.config.packages_path)

I wonder, do we need this ?

[mottosso]

I wonder, do we need this ?

No you're right. This was a concious oversight, given the first user of the project was file-based only. We can safely remove that I think. Ideally, we'd normalise if we're sure it's a path (which I think we can programatically determine), but it's a luxury that the user can manage.

[davidlatwe]

but it's a luxury that the user can manage.

Yeah, and I think Rez doesn't change paths (e.g. normpath) as well, until the path hit into the package repository plugins.

With the last commit, everything works now.
I think I can call it a day. ☺️

[davidlatwe]

To visualize what changes did I made in commit 2b94ae6 :

Before

After

[mottosso]

I'm happy with this when you are, feel free to merge. :)

[davidlatwe]

Thanks :D
Merging this now.