Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change to use variant's root instead of uri #103

Merged
merged 2 commits into from
Oct 12, 2020

Conversation

davidlatwe
Copy link
Collaborator

Problem

If the application package has variants, using uri attribute to format path like {root}/sub-dir is incorrect.

For example (the default is the variant) :

> pkg.uri
/Users/davidlatwe/rez/packages/install/mockmaya/2018/package.py[0]
> pkg.root
/Users/davidlatwe/rez/packages/install/mockmaya/2018/default

Change

Use attribute root when the package object is a variant. ☺️

@davidlatwe davidlatwe requested a review from mottosso August 18, 2020 17:25
@davidlatwe
Copy link
Collaborator Author

Merging this today, patch version will be auto bumped.

@davidlatwe davidlatwe merged commit 7b55650 into mottosso:master Oct 12, 2020
@davidlatwe davidlatwe deleted the fix-package-root branch October 12, 2020 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant