Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow setting parent environment explicitly #122

Merged
merged 9 commits into from
Nov 5, 2020

Conversation

davidlatwe
Copy link
Collaborator

Feature Propose

Allow to provide unified application launching environment from allzparkconfig.py.

Motivation

Allzpark can be launched in various way, e.g. from a Python virtual environment, or a Rez resolved context. And Allzpark can be backed with bleeding-rez or nerdvegas/rez, which has a bit different base environment control scheme between two approaches.

To overcome those differences and other surprises, allowing subprocess (application) parent environment to be set in allzparkconfig.py would be the most straight forward and effective solution.

Additional Features

  • Add "Parent" tab in "Environment" dock page to show current parent environment.
  • Add "Diagnose" tab in "Environment" dock page to show actual subprocess environment.
  • Add "Code" tab in "Context" dock page to show script that is used to spawn shell from resolved context.

ca88084c-cc0f-4d0a-8246-a92b294a037e

@mottosso
Copy link
Owner

mottosso commented Nov 4, 2020

Wow, this is great. :D Get Shell Code is brilliant, it's one of those obscure things about Rez you don't really think about but should really know, and want to know once you start running into odd behaviors with the result. Great job, I have no notes.

@davidlatwe
Copy link
Collaborator Author

Thanks @mottosso :D
Merging this today 🚀

@davidlatwe davidlatwe merged commit c4c10ab into mottosso:master Nov 5, 2020
@davidlatwe davidlatwe deleted the feature/parent-environ branch November 5, 2020 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants