Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make unresolvable App fails independently #124

Merged
merged 15 commits into from
Nov 11, 2020

Conversation

davidlatwe
Copy link
Collaborator

Problem

If an application package is missing or it's dependency is missing, will raise PackageFamilyNotFoundError or PackageNotFoundError and failling whole profile.

Screenshot

image

Proposal

I think it could be more atomic, handling application that have missing packages, and continue to resolve other.

Screenshot

image

Additional Improvement

Features like, launching application tool, diagnose environment, graphing resolved context,.. will be blocked if selected application is broken (resolve failed).

Implementation details

  • Profile package will be resolved solely at first, then resolve with each app if profile itself is solvable.
  • Some of the checkBox widgets which created with qargparse.py were emitting value changed signal twice in one click, which may trigger data model reset twice and leads to crash. E.g. "Use Development Pakcages" check box. Updating qargparse.py fixed the issue.
  • Two controller state were added, appfailed and appok, for triggering feature block/unblock.
  • Added more tests with a bit improvement. Running tests on Azure DevOps are much stable now, but there are still have a little chance occurring Segmentation fault on Ubuntu. I have got Ubuntu installed on my Windows with WSL2 and running tests locally, still not able to reproduce that Segmentation fault. :/

@davidlatwe
Copy link
Collaborator Author

but there are still have a little chance occurring Segmentation fault on Ubuntu.

Currently, when that happened, press the "Re-Run" in PR's "Checks" page to give it another shot. 🤕

@davidlatwe
Copy link
Collaborator Author

davidlatwe commented Nov 9, 2020

If this gets merged, I think we should bump minor version number.
Update: Ignore that, I'll just make a separate release.

@davidlatwe
Copy link
Collaborator Author

Merging this today :)

`qualified_name` is needed on package filtering.
@davidlatwe davidlatwe merged commit 6ee49bf into mottosso:master Nov 11, 2020
@davidlatwe davidlatwe deleted the feature/allow-failed-app branch November 13, 2020 06:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant