-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make unresolvable App fails independently #124
Merged
davidlatwe
merged 15 commits into
mottosso:master
from
davidlatwe:feature/allow-failed-app
Nov 11, 2020
Merged
Make unresolvable App fails independently #124
davidlatwe
merged 15 commits into
mottosso:master
from
davidlatwe:feature/allow-failed-app
Nov 11, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
model reset multiple times with fast clicking.
Currently, when that happened, press the "Re-Run" in PR's "Checks" page to give it another shot. 🤕 |
|
Merging this today :) |
`qualified_name` is needed on package filtering.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
If an application package is missing or it's dependency is missing, will raise
PackageFamilyNotFoundError
orPackageNotFoundError
and failling whole profile.Screenshot
Proposal
I think it could be more atomic, handling application that have missing packages, and continue to resolve other.
Screenshot
Additional Improvement
Features like, launching application tool, diagnose environment, graphing resolved context,.. will be blocked if selected application is broken (resolve failed).
Implementation details
qargparse.py
were emitting value changed signal twice in one click, which may trigger data model reset twice and leads to crash. E.g. "Use Development Pakcages" check box. Updatingqargparse.py
fixed the issue.appfailed
andappok
, for triggering feature block/unblock.Segmentation fault
on Ubuntu. I have got Ubuntu installed on my Windows with WSL2 and running tests locally, still not able to reproduce thatSegmentation fault
. :/