-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #131 #132
Merged
Merged
Fixes #131 #132
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
76c2880
Add 'package_filter' arg to package iteration utils
e4cb44e
Docstring
2d6c3c2
Docstring, reference issue #131
db6906f
Merge branch 'master' of https://github.com/evil-g/allzpark
525964c
Cleanup
02779e3
Add unittest for #131
986230f
Dict syntax error
1151976
Dict syntax error
be169e4
Fix util reference
ce82c08
Syntax error app name
f401a11
Test - update app request check
4a5e356
Merge branch 'master' into master
davidlatwe File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just leaving notes:
While I was resolving merge conflict, I found #129 actually also accidentally fixed the issue that this PR is aiming to. In #129, instead of using
_rez_api.find_latest
, it has changed to use contorller'sfind
method which already filtering packages with filter.Still, removing this line here is good, it's redundant anyway.