Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove redundant array assignments #11

Merged
merged 1 commit into from
Mar 28, 2022
Merged

Remove redundant array assignments #11

merged 1 commit into from
Mar 28, 2022

Conversation

yurivish
Copy link
Contributor

@yurivish yurivish commented Dec 29, 2021 •
edited
Loading

Hello! Thanks for writing this package.

I noticed that the code for push assigned to this.ids and this.values twice, both before and after the sift loop.

This PR removes the extra assignments and passes tests.

mourner
mourner approved these changes Mar 28, 2022
View reviewed changes
Copy link
Owner

@mourner mourner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for missing this and nice catch!

@mourner mourner merged commit 61bf898 into mourner:master Mar 28, 2022
@yurivish
Copy link
Contributor Author

<3 no worries – thanks for everything!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mourner mourner mourner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yurivish @mourner