Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Port parallel planning reviews from MoveIt1 #1699

Merged
merged 2 commits into from
Nov 8, 2022
Merged

Port parallel planning reviews from MoveIt1 #1699

merged 2 commits into from
Nov 8, 2022

Conversation

sjahr
Copy link
Contributor

@sjahr sjahr commented Nov 7, 2022

Description

This PR ports addressed reviews from @rhaschke to MoveIt2. Most importantly, bool generatePlan(...) becomes const again 👍

Checklist

  • Required by CI: Code is auto formatted using clang-format
  • Extend the tutorials / documentation reference
  • Document API changes relevant to the user in the MIGRATION.md notes
  • Create tests, which fail without this PR reference
  • Include a screenshot if changing a GUI
  • While waiting for someone to review your request, please help review another open pull request to support the maintainers

@codecov
Copy link

codecov bot commented Nov 7, 2022 •
edited
Loading

Codecov Report

Base: 50.97% // Head: 50.97% // No change to project coverage 👍

Coverage data is based on head (a7af4f8) compared to base (abbbb9d).
Patch has no changes to coverable lines.

❗ Current head a7af4f8 differs from pull request most recent head 83039e4. Consider uploading reports for the commit 83039e4 to get more accurate results

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #1699   +/-   ##
=======================================
  Coverage   50.97%   50.97%           
=======================================
  Files         378      378           
  Lines       31649    31649           
=======================================
  Hits        16131    16131           
  Misses      15518    15518

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

rhaschke
rhaschke reviewed Nov 7, 2022
View reviewed changes
Copy link
Contributor

@rhaschke rhaschke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only two nitpicks:

moveit_ros/planning/moveit_cpp/include/moveit/moveit_cpp/moveit_cpp.h Outdated Show resolved Hide resolved
moveit_ros/planning/moveit_cpp/include/moveit/moveit_cpp/plan_solutions.hpp
@@ -39,6 +39,7 @@

#include <algorithm>
#include <moveit/planning_interface/planning_response.h>
#include <mutex>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is that required now (and not before)?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It build before, probably because we're lucky and the required header was included from somewhere else but I think it is nicer to ensure that everything is included.

@sjahr sjahr requested a review from rhaschke November 7, 2022 17:46
@rhaschke rhaschke merged commit bbb9264 into moveit:main Nov 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rhaschke rhaschke rhaschke approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sjahr @rhaschke