Switch to get for Dict lookup to prevent KeyError #3043
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikeferguson
approved these changes
Oct 27, 2024
sea-bass
added
the
backport-humble
mergify bot
pushed a commit
that referenced
this pull request
Jan 4, 2025
(cherry picked from commit d2ab1b6)
1 task
sea-bass
pushed a commit
that referenced
this pull request
Jan 4, 2025
(cherry picked from commit d2ab1b6) Co-authored-by: Brendan Burns <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If you run the default generated configs for MoveIt on a headless system where
DISPLAYisn't defined in the environment, this code crashes with aKeyError. Switch to usedict.get(DISPLAY, "")which returns""instead ofthrowing.
Checklist