CI: Silent lcov errors

[rhaschke]

Attempt to fix #3110 and #2866.

[rhaschke]

lcov errors are gone: https://github.com/moveit/moveit2/actions/runs/11897940917/job/33153316613
However, SonarScan execution still fails. I don't even know, what SonarScan actually does. @henningkayser, please decide to fix or disable it.

[sea-bass]

SonarScan ingests coverage data, plus runs its own static analysis on the code. It requires re-enabling the paid service, which far as I know has not been enabled since the transition from ros-planning to moveit orgs.

I would support disabling it for now, and having someone enabling it back if they decide to keep paying for the service.

Edit: actually. SonarCloud may be free for open source projects, so it may just need an admin able to link SonarCloud to the new org.

[codecov-commenter]

⚠️ Please install the to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.52%. Comparing base (d962501) to head (29675de).
Report is 152 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #3115      +/-   ##
==========================================
- Coverage   50.74%   45.52%   -5.22%     
==========================================
  Files         392      482      +90     
  Lines       32553    40431    +7878     
==========================================
+ Hits        16517    18401    +1884     
- Misses      16036    22030    +5994     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

---

🚨 Try these New Features:

• Flaky Tests Detection - Detect and resolve failed and flaky tests

[EzraBrooks]

@sea-bass SonarCloud is still set up. It's free for open-source projects and has not ever been a paid plan for moveit2

[EzraBrooks]

I believe the issue is that the SonarCloud API key is not available to PRs from forks (like this one) due to GitHub's very reasonable security measures of not sharing Secrets with CI jobs initiated from other repositories.

I thought that I had disabled running it for branches from forks, but maybe I'm misremembering.

The only two viable long-term solutions - assuming we want to keep SonarCloud, which I'd like us to but I'm not a frequent user of the moveit2 CI - are either disabling the check for PRs from forks (which means getting surprise CI failures after a merge, which seems not ideal) or doing a hack like this: https://michaelheap.com/access-secrets-from-forks/

[sea-bass]

Aha! That makes sense. Thanks @EzraBrooks!

In that case overcoming the lcov stuff should clear things out.

I am on my phone and it's annoying to check whether we already have this, but on other repos we'e set things up so this particular step is conditioned on you running from a fork, and is otherwise skipped.

Why don't we merge this, and I can stick another PR with that logic on there to verify?

[EzraBrooks]

That's probably sensical. I also am not sure if renaming the org from ros-planning to moveit might have broken the old API key (though I'd hope those two things aren't tied together). I don't appear to be an admin on the MoveIt account on SonarCloud, @henningkayser might need to flip some switches to synchronize maintainer status with GitHub so others of us can do things to it?

[sea-bass]

Thank you @rhaschke! I've updated the required actions based on these changes.

[rhaschke]

I've updated the required actions based on these changes.

What exactly do you mean by this? Which actions did need which (other) changes?

[sea-bass]

I've updated the required actions based on these changes.

What exactly do you mean by this? Which actions did need which (other) changes?

Oh, just that adding ccov renamed the rolling-ci job to rolling-ci-ccov, so had to make the new one required, and unrequire the old one.

[sea-bass]

Well, this is annoying. It kicks you off the merge queue when Sonar fails. I will merge this and address the issue after.

Edit: I think this was just flagging a lot of issues on code that was added while SonarScan was not actually getting to run. Namely, 7.1k LOC. Hopefully this is actually more reasonable now that CI is back up

[EzraBrooks]

Thanks for the great work fixing CI! I was meaning to do this myself but it clearly never happened. I've just approved the request to get Codecov fully installed into the moveit org @rhaschke.

side note, the SonarCloud config needs some work from me or @nbbrooks given lessons learned from some other projects.. it's not quite as helpful as it could be since we haven't been iterating on it since it's been broken.

[nbbrooks]

Awesome work @rhaschke and @sea-bass !

I was able to fix sonarcloud's initial confusion of the GH org migration when I was poking at #3068 - the dashboard is here https://sonarcloud.io/organizations/moveit (I did not need to make a new key). It is not fully functional yet, but at least the job is running and talking to the dashboard.

[rhaschke]

I've just approved the request to get Codecov fully installed into the moveit org @rhaschke.

Unfortunately, codecov is still not correctly configured for the moveit repo:

Do you mind adding me as a moveit org admin?

[nbbrooks]

I will look into the admin assignment separately, but moveit2's ccov was deactivated for some reason, I activated it.

[nbbrooks]

Nevermind, it redirected me to my personal fork's ccov page :(

moveit's was activated so it is something else.

[nbbrooks]

@rhaschke where are you seeing that? It looks like your upload failed, but succeeded for a separate PR's job (Enhancement/use hpp for headers) a few hours ago

https://app.codecov.io/github/moveit/moveit2/pulls

[rhaschke]

@nbbrooks: I'm asking for MoveIt1:
https://github.com/moveit/moveit/actions/runs/11910451831/job/33208735806#step:12:3553

[rhaschke]

Looks like ccov is installed now. However, it states that I should use an upload token.
Didn't you disable the upload tokens in ccov settings: https://app.codecov.io/account/gh/moveit/org-upload-token

[nbbrooks]

The org setting in codecov was "Required" - I have changed it to "Not required" to solve one thing at a time.

Once we have tings up and running we can decide if we want to add some upload protection by sticking it into a GitHub org secret for the codecov/codecov-action action to use.

I retriggered your https://github.com/moveit/moveit/actions/runs/11910451831 job to test if this resolves things.

[rhaschke]

Thanks. Now it worked.