This repository has been archived by the owner on Dec 6, 2019. It is now read-only.
Major overhaul! #30
Merged
Major overhaul! #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
satazor
force-pushed
the
v2
branch
2 times, most recently
from
e158126 to
73ee47f
Compare
This was referenced Nov 20, 2017
| // If it's not a public file, render the app! | ||
| app.use( | ||
| // There's no compilation to be done, just set the `res.locals` | ||
| (req, res, next) => { |
There was a problem hiding this comment.
Isn't this block duplicated? Locals are already being copied above
There was a problem hiding this comment.
Yep it is. removed!
scripts/start-dev
Outdated
| memoryFs, | ||
| watchDelay: 50, | ||
| watchOptions: { poll }, | ||
| notify: { icon: `${publicDir}/favicon.ico` }, // OS notitifications! |
src/App.js
Outdated
| @@ -6,6 +6,10 @@ import Footer from './footer/Footer'; | |||
| import styles from './App.css'; | |||
| import { default as buildPageRoutes } from './pages/buildRoutes'; | |||
There was a problem hiding this comment.
import buildPageRoutes from './pages/buildRoutes';
satazor
force-pushed
the
v2
branch
2 times, most recently
from
a73f3af to
b86ae05
Compare
- Embrace env variables + dotenv - Update to webpack 3 and react 16 - Use our babel preset-moxy - Update all bin files and move them to scripts, to match the upcoming move of those files to react-with-moxy-scripts - Update _reboot.css - Add test script that uses Jest - Add commitlint and standard-version: embrace conventional commits! - Use webpack-isomorphic-compiler and webpack-isomorphic-dev-middleware - Use the new uglify-es - And a lot of minor improvements! Closes #18, #15, #12, #11, #5, #4.
satazor
added a commit
that referenced
this pull request
Nov 21, 2017
satazor
added a commit
that referenced
this pull request
Nov 21, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here's a quick summary:
Closes #18, #15, #12, #11, #5, #4.
Here's the bundle size improvements:
before:
after:
What's next: