Fix creation of error on client registration (CZ-NIC#450)

Close CZ-NIC#449

CHANGELOG.md

@@ -16,13 +16,15 @@ The format is based on the [KeepAChangeLog] project.
 - [#399] Matching response_types for authz requests is too strict
 - [#436] Fixed client.read_registration
 - [#446] Fixed provider.read_registration
+- [#449] Fixed creation of error_response on client registration
 
 [#430]: https://github.com/OpenIDC/pyoidc/pull/430
 [#427]: https://github.com/OpenIDC/pyoidc/pull/427
 [#399]: https://github.com/OpenIDC/pyoidc/issues/399
 [#436]: https://github.com/OpenIDC/pyoidc/pull/436
 [#443]: https://github.com/OpenIDC/pyoidc/pull/443
 [#446]: https://github.com/OpenIDC/pyoidc/issues/446
+[#449]: https://github.com/OpenIDC/pyoidc/issues/449
 
 ## 0.12.0 [2017-09-25]
 

src/oic/oic/provider.py

@@ -1356,7 +1356,7 @@ def do_client_registration(self, request, client_id, ignore=None):
             try:
                 _cinfo["si_redirects"], _cinfo["sector_id"] = self._verify_sector_identifier(request)
             except InvalidSectorIdentifier as err:
-                return error_response("invalid_configuration_parameter", descr=err)
+                return error_response("invalid_configuration_parameter", descr=str(err))
         elif "redirect_uris" in request:
             if len(request["redirect_uris"]) > 1:
                 # check that the hostnames are the same

tests/test_oic_provider.py

@@ -799,6 +799,18 @@ def test_registration_endpoint_unicode(self):
                     'client_id', 'client_secret',
                     'client_id_issued_at', 'response_types'])
 
+    def test_do_client_registration_invalid_sector_uri(self):
+        rr = RegistrationRequest(operation='register', sector_identifier_uri='https://example.com',
+                                 redirect_uris=['http://example.com/changed'])
+        redirects = ['http://example.com/present']
+        with responses.RequestsMock() as rsps:
+            rsps.add(rsps.GET, 'https://example.com', body=json.dumps(redirects))
+            resp = self.provider.do_client_registration(rr, 'client0')
+
+        assert resp.status == '400 Bad Request'
+        error = json.loads(resp.message)
+        assert error['error'] == 'invalid_configuration_parameter'
+
     def test_registration_endpoint_with_non_https_redirect_uri_implicit_flow(
             self):
         params = {"application_type": "web",