Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some notes about landing strings early in feature development. #290

Merged
merged 4 commits into from
Dec 5, 2024

Conversation

mikeconley
Copy link
Contributor

This is based on some conversations I've had with @bcolsson and @flodolo recently about the New Tab team's intent to ship more quickly, and thought it'd be worth adding to the documentation.

@mikeconley mikeconley requested a review from a team as a code owner December 2, 2024 16:00
@flodolo flodolo requested review from bcolsson and removed request for a team December 2, 2024 16:10
Copy link
Contributor

@bcolsson bcolsson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this @mikeconley - I had some thoughts and provided a couple suggestions to get the conversation started. I think in general our stance is that unless there's a good reason, people should be landing strings at the same time as the other changes.

src/products/firefox_desktop/firefox_l10n_faqs.md Outdated Show resolved Hide resolved
@mikeconley
Copy link
Contributor Author

Thanks for adding this @mikeconley - I had some thoughts and provided a couple suggestions to get the conversation started. I think in general our stance is that unless there's a good reason, people should be landing strings at the same time as the other changes.

Should we provide some examples of what would qualify as good reasons?

@bcolsson
Copy link
Contributor

bcolsson commented Dec 3, 2024

Thanks for adding this @mikeconley - I had some thoughts and provided a couple suggestions to get the conversation started. I think in general our stance is that unless there's a good reason, people should be landing strings at the same time as the other changes.

Should we provide some examples of what would qualify as good reasons?

Good point, though at this point I can only think of one example where we are considering this, so I think we can use your proposed use case (features releasing outside of the normal train release model) as an example.

@bcolsson bcolsson merged commit 9b19a51 into mozilla-l10n:main Dec 5, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants