Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update go.mod #3

Merged
merged 6 commits into from
Jul 25, 2018
Merged

update go.mod #3

merged 6 commits into from
Jul 25, 2018

Conversation

g-k
Copy link
Contributor

@g-k g-k commented Jul 25, 2018 •
edited
Loading

refs: https://bugzilla.mozilla.org/show_bug.cgi?id=1477319 for autograph 1.0.2 deploy (I'll need to tag a new release and update the bug)

Changes:

  • update dep versions
  • add dep hashes in go.sum
  • fix CI "go: error loading module requirements" errors per cmd/go: module fetch errors are unclear golang/go#26594 these were due to an older git version 2.11
  • add clang to CI and Dockerfile so vgo build run as part of vgo install passes

r? @milescrabill

@g-k g-k force-pushed the fix-vgo-install branch from 79466d2 to ebd91cd Compare July 25, 2018 17:16
@g-k g-k force-pushed the fix-vgo-install branch from 57f099b to bca7dcf Compare July 25, 2018 18:11
@g-k g-k force-pushed the fix-vgo-install branch from 273127c to 4abb555 Compare July 25, 2018 18:26
@g-k g-k requested a review from milescrabill July 25, 2018 18:34
milescrabill
milescrabill approved these changes Jul 25, 2018
View reviewed changes
Copy link

@milescrabill milescrabill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r+ once nits fixed

.circleci/config.yml
apt update
apt install -y libltdl-dev netcat
apt install -y libltdl-dev netcat clang
apt-get -y -t stretch-backports install git
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

interesting that git isn't in the mainline repo

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah 2.18 was just released in Jun. I think vgo is using Transfer protocol v2 for partial clones.

Dockerfile Outdated
@@ -3,13 +3,14 @@ MAINTAINER Mozilla
EXPOSE 8080

RUN addgroup --gid 10001 app && \

# \
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove this

Dockerfile Outdated
adduser --gid 10001 --uid 10001 \
--home /app --shell /sbin/nologin \
--disabled-password app && \

# \
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and this. and maybe make the apt stuff a separate RUN step

@g-k g-k force-pushed the fix-vgo-install branch from 4abb555 to 7aeab97 Compare July 25, 2018 19:17
@g-k g-k merged commit c61f1cc into master Jul 25, 2018
@g-k g-k deleted the fix-vgo-install branch July 25, 2018 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@milescrabill milescrabill milescrabill approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@g-k @milescrabill