Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Actually use the calculated window width #5422

Merged
merged 2 commits into from
Sep 17, 2024
Merged

Conversation

fregante
Copy link
Contributor

@fregante fregante commented Aug 25, 2024

In my tests:

  • real: 100 ch
  • maxColumns: 98 ch
  • printed: 122 ch

I don't know exactly why columnify is returning a line that is that long, but this fixes it.

Demo

demo

Copy link

codecov bot commented Sep 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.77%. Comparing base (3b8b127) to head (bc39315).
Report is 5 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5422   +/-   ##
=======================================
  Coverage   98.77%   98.77%           
=======================================
  Files          51       51           
  Lines        2855     2855           
  Branches      867      867           
=======================================
  Hits         2820     2820           
  Misses         35       35           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@willdurand willdurand merged commit 72a18ee into mozilla:master Sep 17, 2024
5 checks passed
@willdurand
Copy link
Member

Thanks!

@fregante fregante deleted the fit branch September 17, 2024 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The report table is always wider than terminal
2 participants