Rename-release #22364
Merged
Rename-release #22364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KevinMind
force-pushed
the
rename-release
branch
from
7a6f452 to
84b455c
Compare
…rkflow to finish before triggering deployment
|
I'm going to merge this as it can only be tested on the default branch and does not significantly impact anything. |
This was referenced Jun 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to: mozilla/addons#14823
Companion to: https://github.com/mozilla-sre-deploy/deploy-amo/pull/4
Description
This PR introduces a
Release.ymlworkflow that is triggered on releasepublishedevents. This workflow currently builds our docker image using the tag that was linked to the release and will eventually be how we push our deployment image to a registry where it can then be shipped.Context
This job can only be triggered if it is included in the tag that creates the release (kind of weird gotcha in github releases)
This job doesn't currently push to a registry, though will likely eventually push directly to GAR.
This job doesn't currently have any logic to verify that the deployment is actually successful once the image is uploaded, but this could be done.
The workflow doesn't verify the image the way the ci.yml does. This should be considered in follow up work. Maybe integrate the two workflows, or find a way to triggere the ci.yml workflow as a part of the release. THere is too much to consider for here, how to make the release blocked by success, how to roll back if it fails etc. etc.
Testing
You can test this by pushing a tag that has this commit and then publishing a release with that tag.