Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow URLs in developer replies to ratings #22749

Merged
merged 1 commit into from
Oct 16, 2024

Conversation

diox
Copy link
Member

@diox diox commented Oct 9, 2024

@diox diox requested review from a team and KevinMind and removed request for a team October 9, 2024 15:58
@KevinMind
Copy link
Contributor

Can you add some testing steps?

@diox
Copy link
Member Author

diox commented Oct 10, 2024

  1. Log in as a regular user
  2. Try posting a rating with an URL - it shouldn't work.
  3. Post a rating on an add-on
  4. Log in as a developer of that add-on
  5. Post a reply to the rating posted earlier with an URL - it should work.

Copy link
Contributor

@KevinMind KevinMind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. FWIW I could add www.google.com but not https://www.google.com Probably difficult to get lower level that protocol checking but wanted to shout.

@KevinMind
Copy link
Contributor

I was able to review with www.google.com but not https://www.google.com

Screenshot 2024-10-16 at 17 36 07

I could reply even with https...

Screenshot 2024-10-16 at 17 39 06

@diox
Copy link
Member Author

diox commented Oct 16, 2024

Yeah we're not trying to detect things that may look like an URL - we used to, when we were transforming them into links automatically, but we don't anymore so really the check is just to add an extra layer to keep our ratings as clean as possible.

when we were doing that detection it was very prone to errors. There are some many TLDs these days that it's too messy.

@diox diox merged commit a26bf81 into mozilla:master Oct 16, 2024
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Task]: Allow URLs in developer replies to add-on ratings
2 participants