Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't set forwarded to legal job as resolvable_in_reviewer_tools #22973

Conversation

eviljeff
Copy link
Member

@eviljeff eviljeff commented Jan 6, 2025

Fixes: mozilla/addons#15255 and fixes mozilla/addons#15259

Description

Sets resolvable_in_reviewer_tools to False for jobs (re)created when a job/add-on is forwarded to legal in Cinder.

Context

When resolvable_in_reviewer_tools is True we ignore the actions (15255) and also don't clear the NHRs (15259).

Testing

  • forward a job from the reviewer tools and see that the NHR that lead to the add-on being in the review queue is cleared
    • the edge case here is a job that was itself forwarded from Cinder - that should also lose it's NHR
  • check the new CinderJob (use django shell to find it) is resolvable_in_reviewer_tools=False

Checklist

  • Add #ISSUENUM at the top of your PR to an existing open issue in the mozilla/addons repository.
  • Successfully verified the change locally.
  • The change is covered by automated tests, or otherwise indicated why doing so is unnecessary/impossible.
  • Add before and after screenshots (Only for changes that impact the UI).
  • Add or update relevant docs reflecting the changes made.

@eviljeff eviljeff requested review from a team and diox and removed request for a team January 6, 2025 17:43
@eviljeff eviljeff merged commit 1656bff into mozilla:master Jan 7, 2025
49 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants