This repository has been archived by the owner on Jan 24, 2019. It is now read-only.
Generate thumbnail generation tails after a bulk transaction #167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } | ||
| var row = result.rows[0]; | ||
| server.methods.pages.min([ | ||
| page.project_id |
There was a problem hiding this comment.
I'm curious about this - what's the reason that you want the lowest page id in a project?
There was a problem hiding this comment.
Like, is the lowest page id always guaranteed to be the center?
There was a problem hiding this comment.
That's what we determined to be "the thumbnail page" for all projects. in most cases, it's the first page made, unless they delete it.
| pendingUpdates.push(result); | ||
| return pendingUpdates; | ||
| }, []) | ||
| .map(function(result) { |
There was a problem hiding this comment.
I think this should be a forEach since you're not returning the value here, right?
|
i am r+ this with several conditions:
|
|
@cadecairos r+ |
|
@ashleygwilliams Lets file some issues around those points |
cadecairos
pushed a commit
that referenced
this pull request
Aug 19, 2015
Generate thumbnail generation tails after a bulk transaction
This was referenced Aug 19, 2015
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #165
This PR is missing three lines of test coverage. We need to craft specific test payloads so that these code paths can be executed.
cc/ @ashleygwilliams & @jbuck