Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add date filter to firefox_android_clients_check #4538

Closed
wants to merge 1 commit into from

Conversation

scholtzan
Copy link
Collaborator

@scholtzan scholtzan commented Nov 9, 2023

This check needs a submission_date filter, not sure if this is set correctly though...

Checklist for reviewer:

  • Commits should reference a bug or github issue, if relevant (if a bug is referenced, the pull request should include the bug number in the title).
  • If the PR comes from a fork, trigger integration CI tests by running the Push to upstream workflow and provide the <username>:<branch> of the fork as parameter. The parameter will also show up
    in the logs of the manual-trigger-required-for-fork CI task together with more detailed instructions.
  • If adding a new field to a query, ensure that the schema and dependent downstream schemas have been updated.
  • When adding a new derived dataset, ensure that data is not available already (fully or partially) and recommend extending an existing dataset in favor of creating new ones. Data can be available in the bigquery-etl repository, looker-hub or in looker-spoke-default.

For modifications to schemas in restricted namespaces (see CODEOWNERS):

┆Issue is synchronized with this Jira Task

@scholtzan scholtzan requested a review from kik-kik November 9, 2023 17:14
@scholtzan
Copy link
Collaborator Author

superseded by #4539

@scholtzan scholtzan closed this Nov 9, 2023
@dataops-ci-bot
Copy link

Integration report for "Add date filter to firefox_android_clients_check"

sql.diff

Click to expand!
Only in /tmp/workspace/generated-sql/sql/: glam-fenix-dev
Only in /tmp/workspace/generated-sql/sql/: moz-fx-cjms-nonprod-9a36
Only in /tmp/workspace/generated-sql/sql/: moz-fx-cjms-prod-f3c7
Only in /tmp/workspace/generated-sql/sql/: moz-fx-data-bq-performance
Only in /tmp/workspace/generated-sql/sql/: moz-fx-data-experiments
Only in /tmp/workspace/generated-sql/sql/: moz-fx-data-marketing-prod
Only in /tmp/workspace/generated-sql/sql/: moz-fx-data-shared-prod
Only in /tmp/workspace/generated-sql/sql/: mozfun
Only in /tmp/workspace/main-generated-sql/sql/: sql

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants