Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(): updating fxa android funnel to support install_source filtering downstream #4561

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ SELECT
COALESCE(retention_week_4.adjust_campaign, retention_week_2.adjust_campaign) AS adjust_campaign,
COALESCE(retention_week_4.adjust_creative, retention_week_2.adjust_creative) AS adjust_creative,
COALESCE(retention_week_4.adjust_network, retention_week_2.adjust_network) AS adjust_network,
COALESCE(retention_week_4.install_source, retention_week_2.install_source) AS install_source,
retention_week_2.retained_week_2,
retention_week_4.retained_week_4,
retention_week_4.days_seen_in_first_28_days,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ clients_first_seen AS (
adjust_campaign,
adjust_creative,
adjust_network,
install_source,
FROM
fenix.firefox_android_clients
WHERE
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,11 @@ fields:
description: |
The type of source of a client installation.

- mode: NULLABLE
name: install_source
type: STRING
description:

- mode: NULLABLE
name: retained_week_2
type: BOOLEAN
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ clients_first_seen AS (
adjust_campaign,
adjust_creative,
adjust_network,
install_source,
FROM
fenix.firefox_android_clients
WHERE
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,11 @@ fields:
description: |
The type of source of a client installation.

- mode: NULLABLE
name: install_source
type: STRING
description:

- mode: NULLABLE
name: days_seen_in_first_28_days
type: INTEGER
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ SELECT
adjust_campaign,
adjust_creative,
adjust_network,
install_source,
COUNT(*) AS new_profiles,
COUNTIF(repeat_first_month_user) AS repeat_user,
COUNTIF(retained_week_4) AS retained_week_4,
Expand All @@ -22,4 +23,5 @@ GROUP BY
adjust_ad_group,
adjust_campaign,
adjust_creative,
adjust_network
adjust_network,
install_source
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,11 @@ fields:
description: |
The type of source of a client installation.

- mode: NULLABLE
name: install_source
type: STRING
description:

- mode: NULLABLE
name: new_profiles
type: INTEGER
Expand Down