Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1864722 - Fix column name typo #4567

Merged
merged 1 commit into from
Nov 14, 2023
Merged

Bug 1864722 - Fix column name typo #4567

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion sql/moz-fx-data-shared-prod/telemetry_derived/clients_first_seen_v2/query.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -374,7 +374,7 @@ main_ping AS (
ARRAY_AGG(normalized_os_version RESPECT NULLS ORDER BY submission_date)[
SAFE_OFFSET(0)
] AS normalized_os_version,
ARRAY_AGG(startup_profile_selection_reason_first_ping_only RESPECT NULLS ORDER BY submission_date)[
ARRAY_AGG(startup_profile_selection_first_ping_only RESPECT NULLS ORDER BY submission_date)[
SAFE_OFFSET(0)
] AS startup_profile_selection_reason,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this startup_profile_selection_reason column name still make sense given the upstream column name is different?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not perfectly (the upstream was also a typo 🤦) but the column description does clarify somewhat

ARRAY_AGG(attribution.dltoken RESPECT NULLS ORDER BY submission_date)[
Expand Down
2 changes: 1 addition & 1 deletion sql/moz-fx-data-shared-prod/telemetry_derived/clients_last_seen_joined_v1/schema.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2110,7 +2110,7 @@ fields:
- name: startup_profile_selection_reason_first
type: STRING
mode: NULLABLE
- name: startup_profile_selection_reason_first_ping_only
- name: startup_profile_selection_first_ping_only
type: STRING
mode: NULLABLE
- name: first_document_id
Expand Down
2 changes: 1 addition & 1 deletion ...ents_first_seen_v2/moz-fx-data-shared-prod.telemetry_derived.clients_daily_v6.schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,6 +163,6 @@
},
{
"type": "STRING",
"name": "startup_profile_selection_reason_first_ping_only"
"name": "startup_profile_selection_first_ping_only"
}
]