Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(DENG-2174): add accepted values check #4650

Merged
merged 4 commits into from
Dec 15, 2023
Merged

Conversation

lelilia
Copy link
Contributor

@lelilia lelilia commented Dec 5, 2023

adding accepted values data check

┆Issue is synchronized with this Jira Task

@dataops-ci-bot

This comment has been minimized.

Copy link
Contributor

@kik-kik kik-kik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add the missing ;, otherwise LGTM 🥳

@lelilia lelilia enabled auto-merge (squash) December 11, 2023 16:25
@dataops-ci-bot

This comment has been minimized.

@dataops-ci-bot
Copy link

Integration report for "Merge branch 'main' into new_data_check_macros"

sql.diff

Click to expand!
diff -bur --no-dereference --new-file /tmp/workspace/main-generated-sql/sql/moz-fx-data-shared-prod/telemetry/releases_latest/schema.yaml /tmp/workspace/generated-sql/sql/moz-fx-data-shared-prod/telemetry/releases_latest/schema.yaml
--- /tmp/workspace/main-generated-sql/sql/moz-fx-data-shared-prod/telemetry/releases_latest/schema.yaml	2023-12-11 16:41:46.000000000 +0000
+++ /tmp/workspace/generated-sql/sql/moz-fx-data-shared-prod/telemetry/releases_latest/schema.yaml	2023-12-11 16:34:01.000000000 +0000
@@ -2,18 +2,21 @@
 - name: date
   type: DATE
   mode: NULLABLE
+  description: null
 - name: product
   type: STRING
   mode: NULLABLE
 - name: category
   type: STRING
   mode: NULLABLE
+  description: null
 - name: channel
   type: STRING
   mode: NULLABLE
 - name: build_number
   type: INTEGER
   mode: NULLABLE
+  description: null
 - name: release_date
   type: DATE
   mode: NULLABLE

Link to full diff

@lelilia lelilia changed the title add accepted values check feat(DENG-2174): add accepted values check Dec 12, 2023
@lelilia lelilia merged commit 699b325 into main Dec 15, 2023
@lelilia lelilia deleted the new_data_check_macros branch December 15, 2023 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants