Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use checks api #1920

Merged
merged 1 commit into from
Oct 12, 2023
Merged

Use checks api #1920

merged 1 commit into from
Oct 12, 2023

Conversation

lotas
Copy link
Contributor

@lotas lotas commented Oct 10, 2023

Switch to checks API.

Also test build pipeline, why tasks are deadline expired

@lotas
Use checks api
f36a9f3 
Switch to checks API.

Also test build pipeline, why tasks are deadline expired

Update .taskcluster.yml

trigger rerun
@mergify mergify bot mentioned this pull request Oct 10, 2023
Closed
@lotas lotas mentioned this pull request Oct 10, 2023
Open
@abpostelnicu
Copy link
Collaborator

@lotas what is this suppose to do?

@lotas
Copy link
Contributor Author

lotas commented Oct 12, 2023

@lotas what is this suppose to do?

Github initially had Statuses API only, that was the default option, where jobs would be attached to the commit directly (iirc) and were quite limited.
They later introduced Checks API, and it has more features. For example those runs can now be seen on the PR level:
https://github.com/mozilla/code-review/pull/1920/checks (extra tab) and also allows to attach extra information like description (task logs) and annotations that you could see in the github UI.
It would also allow to use re-run from github UI to retry failed tasks

@abpostelnicu
Copy link
Collaborator

@lotas is this safe to merge?

@lotas
Copy link
Contributor Author

lotas commented Oct 12, 2023

We fixed community-tc config here: https://github.com/taskcluster/community-tc-config/pull/688/files
so this project can use extra scope queue:route:checks
And FxCI tasks seems to be running just fine, so should be safe yes.

Merged similar on code-coverage also mozilla/code-coverage#2112

@abpostelnicu abpostelnicu merged commit a9c6cca into mozilla:master Oct 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lotas @abpostelnicu