Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(cirrus): V2 api #12061

Merged
merged 1 commit into from
Jan 17, 2025
Merged

feat(cirrus): V2 api #12061

merged 1 commit into from
Jan 17, 2025

Conversation

yashikakhurana
Copy link
Contributor

Because

  • We want to return features under the key Features
  • We don't send back enrollment responses to the calling application and sometimes its hard to find if they are in the experiment or not

This commit

  • Returns feature and enrollments as part of the new v2 api

Fixes #12000 #12001

jaredlockhart
jaredlockhart approved these changes Jan 17, 2025
View reviewed changes
Copy link
Collaborator

@jaredlockhart jaredlockhart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thnx @yashikakhurana 🙏

@jaredlockhart jaredlockhart added this pull request to the merge queue Jan 17, 2025
Merged via the queue into main with commit 59bacb1 Jan 17, 2025
16 checks passed
@jaredlockhart jaredlockhart deleted the revert-12056-revert-12008-12000/cirrus_v2_api_enrollment_data branch January 17, 2025 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaredlockhart jaredlockhart jaredlockhart approved these changes

@jeddai jeddai Awaiting requested review from jeddai jeddai is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

v2 api-Cirrus returns the enrollment data in the response
2 participants
@yashikakhurana @jaredlockhart