Merge pull request #1013 from mozilla/fix-nps-again

eventValue determines NPS segment; not array index
mozilla · Aug 16, 2021 · 4d538d1 · 4d538d1
2 parents 6fe5831 + bd8e87f
commit 4d538d1
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/static/js/analytics.js b/static/js/analytics.js
@@ -168,10 +168,10 @@ function analyticsSurveyLogic() {
         li.dataset.eventCategory = "NPS Survey";
         li.dataset.eventAction = "submitted";
         li.dataset.eventValue = option + 1;
-        if (option <= 6) {
+        if (li.dataset.eventValue <= 6) {
           li.dataset.eventLabel = "detractor";
           li.dataset.npsValue = -1;
-        } else if (option <= 8) {
+        } else if (li.dataset.eventValue <= 8) {
           li.dataset.eventLabel = "passive";
           li.dataset.npsValue = 0;
         } else {