Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mozilla VPN promotional banner still displayed after closing it #963

Closed
Bianca-O opened this issue Jul 27, 2021 · 1 comment
Closed

Mozilla VPN promotional banner still displayed after closing it #963

Bianca-O opened this issue Jul 27, 2021 · 1 comment
Labels
🐛 bug Something isn't working

Comments

@Bianca-O
Copy link
Collaborator

Bianca-O commented Jul 27, 2021

Build:
Stage

Affected platforms:
Windows 10 64-bit
macOS 10.14
Android 11
iOS 14.6

Browsers tested on:
Firefox

Steps to reproduce:

  1. Launch Firefox with a new profile.
  2. Navigate to https://stage.fxprivaterelay.nonprod.cloudops.mozgcp.net and log in using an existing account.
  3. Close the Mozilla VPN promotion banner.
  4. Click FAQ.
  5. Observe that Mozilla VPN promotion banner is still displayed.

Actual result:
Mozilla VPN promotion banner is still displayed on FAQ page after closing it on Home page.

Expected result:
Mozilla VPN promotion banner is not displayed anymore after closing it.

Note:
If the user is logged out and the promotional banner is closed on Home page it is not displayed anymore on FAQ page.

VPN banner still displayed

@maxxcrawford
Copy link
Contributor

I took it a step further – if a user dismisses it on home/FAQ and THEN logs in, the banner stays hidden. It's only when they dismiss from the signed-in dashboard. Weird.

I experimented with adding secure; and SameSite=None attributes but no dice.

@maxxcrawford maxxcrawford added the 🐛 bug Something isn't working label Jul 27, 2021
groovecoder added a commit that referenced this issue Aug 18, 2021
…-path

Fix #963 - Set path of vpnBannerDismissed cookie to root
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants