Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The border corners for error message bar are not rounded #971

Closed
Bianca-O opened this issue Jul 28, 2021 · 1 comment
Closed

The border corners for error message bar are not rounded #971

Bianca-O opened this issue Jul 28, 2021 · 1 comment
Assignees

Comments

@Bianca-O
Copy link
Collaborator

Bianca-O commented Jul 28, 2021

Build:
Stage

Affected platforms:
Windows 10 64-bit
macOS 10.14
Android 11
iOS 14.6

Preconditions:
The user has an active MPP subscription.
No email domain added.

Browsers tested on:
Firefox

Steps to reproduce:

  1. Navigate to https://stage.fxprivaterelay.nonprod.cloudops.mozgcp.net/ and log in using an existing account.
  2. In the "Search your new domain" field type a long email domain and click "Get it" to force an error message.
  3. Observe the error message bar.

Actual result:
The corners of the message bar are not rounded.

Expected result:
The corners of the message bar are rounded.

error msg bar

See Figma for reference:
Figma

@AOiegas
Copy link
Collaborator

AOiegas commented Aug 6, 2021

Verified this issue on stage, on both Windows 10 and Android 9. The error message bar appears in the correct shape.
To be noted:

  • The issue #998 appeared;
  • Comparing with the Figma references, there is a length of space missing from beneath the error message bar;
    image
    image

groovecoder added a commit that referenced this issue Oct 24, 2021
…iptions

fix #1093 mpp #971: just check for presence of fxa_refresh url param
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants