Fix #965 - Reset button/item count overlaps search input query on fil… #1007
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxxcrawford
commented
Aug 11, 2021
| <span class="js-filter-case-visible"></span> | ||
| / | ||
| <span class="js-filter-case-total"></span> | ||
| <div class="c-filter-search-controls"> |
There was a problem hiding this comment.
Wrapped the .c-filter-case-count and .c-filter-reset in a containing div.
Comment on lines
+535
to
+536
| if ( document.getElementById("survey-dismiss") ) { | ||
| document.getElementById("survey-dismiss").addEventListener("click", dismissSurvey, false); | ||
| } | ||
|
|
There was a problem hiding this comment.
This was throwing a JS error on pages where the micro-survey-banner did not exist.
Comment on lines
+30
to
+34
| let query = input; | ||
|
|
||
| if (input.target) { | ||
| query = input.target.value.toLowerCase(); | ||
| } |
There was a problem hiding this comment.
let reasoning: this function was retro fit to run on page load if there was a value in the search filed. (Use case: user refreshes the page while some aliases are being filtered)
There was a problem hiding this comment.
cc/ @groovecoder
…e load, add logic to keep the reset button visible if the search bar contains a query, revise JS styles to toggle visibility classes instead of manipulating style.display,
maxxcrawford
force-pushed
the
965-search-bar-overlap
branch
from
bb0717d to
25fc7f0
Compare
codemist
approved these changes
Aug 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes:
STR:
X/Xnumber of items visible/total.