Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change locales/ to a submodule #1012

Merged
merged 1 commit into from
Aug 16, 2021
Merged

change locales/ to a submodule #1012

merged 1 commit into from
Aug 16, 2021

Conversation

groovecoder
Copy link
Member

@groovecoder groovecoder commented Aug 13, 2021

This changes the app repo to use the new l10n repo for its locales/ files.

Test:

  1. Check out this branch
  2. git submodule update --init
  3. Go to http://127.0.0.1:8000/
    • All the UI strings should still work

Notes:

I've updated the .circleci/config.yml file so it will automatically get the submodule contents before it builds. Heroku automatically detects submodules and updates them when deploying code.

From now on, when we want to update the translations for the app - e.g., for a release - we will need to:

  1. git submodule update --remote
  2. git add privaterelay/locales
  3. git commit -m "update translations"
  4. git push

Copy link
Contributor

@maxxcrawford maxxcrawford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌍

@groovecoder groovecoder merged commit d275a74 into main Aug 16, 2021
@groovecoder groovecoder deleted the locales-submodule branch August 16, 2021 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants